Upkeep #27
Merged
Upkeep #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs to be checked
dunkenwg
requested review from
joethorley,
evanamiesgalonski and
sebdalgarno
joethorley
requested changes
Sep 19, 2024
| @@ -107,7 +107,7 @@ test_that("check_flob_query", { | |||
| expect_identical(check_flob_query(slob_obj, slob = TRUE), slob_obj) | |||
| expect_identical(check_flob_query(slob_obj, slob = NA), slob_obj) | |||
|
|
|||
| expect_error(check_flob_query("non-blob", slob = NA), "`x` must be a blob of a serialized object.") | |||
| expect_error(check_flob_query("non-blob", slob = TRUE), "`x` must be a blob of a serialized object.") | |||
There was a problem hiding this comment.
Error:
! `check_flob_query("non-blob", slob = NA)` threw an error with unexpected message.
Expected match: "`x` must be a blob of a serialized object."
Actual message: "`x` must be a list of raw vectors"
|
@joethorley, @sebdalgarno, and @evanamiesgalonski, when you have a chance would you be able to review this pull request? |
joethorley
approved these changes
Nov 5, 2024
|
The conflict should be easy to resolve when we merge. It's just a difference in the README badges |
evanamiesgalonski
approved these changes
Nov 6, 2024
sebdalgarno
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't really know who to put as a reviewer for this, so I decided to be safe and go with all three of you as this package is a CRAN package.
I'm going through our packages that use the set functions and making sure the code still works on the development version of R. You can see more info in this issue.
Something that definitely requires your attention is commit e0b9b32.