Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utility] Support RESTful relays (need to merge #960 first) #961

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented Aug 2, 2023

Description

This PR adds support for relays in REST format, i.e. with JSON payload rather than JSONRPC, and optionally specify a Path and the HTTP Method.

Issue

Part of work on #860

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Update RPC structs and handlers to support REST
  • Update client binary to handle REST
  • Update Servicer logic to handle REST

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@adshmh adshmh added utility Utility specific changes do not merge Prevent merging even with sufficient approvals labels Aug 2, 2023
@adshmh adshmh added this to the M3: Pocket RoS (Relay or Slash) milestone Aug 2, 2023
@adshmh adshmh self-assigned this Aug 2, 2023
@reviewpad reviewpad bot added the large Pull request is large label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Prevent merging even with sufficient approvals large Pull request is large utility Utility specific changes
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant