-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proof] Implement scalable proof validation #1031
Conversation
The image is going to be pushed after the next commit. You can use If you also want to run E2E tests, please add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne I did a first pass of this, but I plan to do a COMPLETE second pass as well.
This is very critical and going to need some work.
@red-0ne Ty for taking all of my feedback in the iteration. Looking much better! I think it should. be g2g after another round of review. |
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1031) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more renaming request. Other than that g2g.
Approving prematively!
@red-0ne Let's also submit a docs PR w/ the diagram we put together in the other discussion. |
Summary
This PR refactors proof validation by distributing it across the proof submission workflow for better scalability.
The validation process is divided into two stages:
ClosestMerkleProof
.Additionally, the proof module endblocker:
ProofStatus
field.The potential supplier slashing is retained within the
SettlePendingClaims
flow, ensuring a clear separation of concerns.Issue
Type of change
Select one or more from the following:
consensus-breaking
label if so. See [Infra] Automatically add theconsensus-breaking
label #791 for detailsTesting
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR.Sanity Checklist