Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMT] Updated smt release from v0.9.2 -> v0.10.2 #472

Merged
merged 9 commits into from
Apr 13, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Apr 9, 2024

Summary

Updating the SMT release post audit.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
  • Documentation changes: make docusaurus_start

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and referenced any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@Olshansk Olshansk added smt Sprase Merkle Tree Related Audit Anythings related to audits labels Apr 9, 2024
@Olshansk Olshansk added this to the Shannon Private TestNet milestone Apr 9, 2024
@Olshansk Olshansk requested a review from red-0ne April 9, 2024 20:52
@Olshansk Olshansk self-assigned this Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Apr 9, 2024
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove

// replace github.com/cosmos/cosmos-sdk => github.com/rollkit/cosmos-sdk v0.50.1-rollkit-v0.11.19-no-fraud-proofs
replace github.com/pokt-network/smt => github.com/pokt-network/smt v0.9.3-0.20240321060129-e3dbbbd9f97d

Present at the end of the file. It was used to get the latest smt changes back then.

@Olshansk Olshansk requested a review from red-0ne April 11, 2024 20:24
@Olshansk Olshansk changed the title [SMT] Updated smt release from v0.9.2 -> v0.10.0 [SMT] Updated smt release from v0.9.2 -> v0.10.2 Apr 11, 2024
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review done.

Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Olshansk Olshansk merged commit fd9fe2b into main Apr 13, 2024
9 checks passed
bryanchriswhite added a commit that referenced this pull request Apr 17, 2024
* pokt/main:
  [TODOs] Add todos for future smt optimizations (#423)
  [Metrics] feat: Initial on-chain metrics implementation (#449)
  [Tooling] Add application stake/unstake/delegate logs (#482)
  [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472)
  [Docs] update supplier actor CLI section (#471)
  [Testing] chore: add make targets & update feature path logging (#470)
  [Metrics] Additional off-chain metrics (#468)
  Update test instructions pull_request_template.md (#473)
  [Tooling] Makefile checkers when starting localnet (#466)
  [LocalNet] Switch validator logs to json (#480)
  [Documentation] Refactor poktroll documentation so its easier to navigate (#474)
  [LocalNet] Add observability stack (#475)
bryanchriswhite added a commit that referenced this pull request Apr 24, 2024
…ment

* pokt/main:
  [Config] feat: Simplify relay miner config (#477)
  [Testing] Add application staking with Makefile targets for app and gateways (#481)
  [LocalNet] Add option to turn on/off delve (#485)
  [SDK] Client TLS Support (#441)
  [TODOs] Add todos for future smt optimizations (#423)
  [Metrics] feat: Initial on-chain metrics implementation (#449)
  [Tooling] Add application stake/unstake/delegate logs (#482)
  [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472)
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
@Olshansk Olshansk deleted the issues/462/update_smt_release branch May 29, 2024 16:44
okdas added a commit that referenced this pull request Nov 14, 2024
Updating the SMT release post audit.

---

Co-authored-by: Dmitry K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit Anythings related to audits smt Sprase Merkle Tree Related
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants