Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LocalNet] Add observability stack #475

Merged
merged 5 commits into from
Apr 11, 2024
Merged

[LocalNet] Add observability stack #475

merged 5 commits into from
Apr 11, 2024

Conversation

okdas
Copy link
Member

@okdas okdas commented Apr 10, 2024

Summary

Brings observability stack to LocalNet.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
  • Documentation changes: make docusaurus_start

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and referenced any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added documentation Improvements or additions to documentation infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc... labels Apr 10, 2024
@okdas okdas added this to the Shannon Private TestNet milestone Apr 10, 2024
@okdas okdas self-assigned this Apr 10, 2024
@okdas okdas requested a review from Olshansk April 10, 2024 23:36
@okdas okdas marked this pull request as ready for review April 10, 2024 23:36
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the data locally (yet) but did manage to access the dashboard so it's a great first step and good enough to merge in!

@@ -0,0 +1,2 @@
loki:
isDefault: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olshansk no, - Prometheus is configured to be the default data source. Can't have two default data sources.

@Olshansk
Copy link
Member

The RelayMiner showed some data! Any idea why the validator hasn't yet?

Screenshot 2024-04-10 at 5 05 07 PM
Screenshot 2024-04-10 at 5 05 03 PM

@okdas okdas merged commit ef3560d into main Apr 11, 2024
11 checks passed
@okdas
Copy link
Member Author

okdas commented Apr 11, 2024

Any idea why the validator hasn't yet?

Do you have this turned on or off in your config?

helm_chart_local_repo:
  enabled: true

If it is enabled, you'd need to pull in the latest changes in the chart repo. You usually don't need to turn on that feature unless you actively develop a helm chart. If it is disabled, and you still experience that issue, please let me know - we can take a look. I just double-checked and it worked on my machine.

bryanchriswhite added a commit that referenced this pull request Apr 11, 2024
* main:
  [Documentation] Refactor poktroll documentation so its easier to navigate (#474)
  [LocalNet] Add observability stack (#475)
  [Tokenomics] Foundation PR to integrate `SessionAccountingSettlement` w/ the Claim & Proof lifecycle (#448)
bryanchriswhite added a commit that referenced this pull request Apr 11, 2024
* main:
  [Documentation] Refactor poktroll documentation so its easier to navigate (#474)
  [LocalNet] Add observability stack (#475)
  [Tokenomics] Foundation PR to integrate `SessionAccountingSettlement` w/ the Claim & Proof lifecycle (#448)
Olshansk added a commit that referenced this pull request Apr 11, 2024
bryanchriswhite added a commit that referenced this pull request Apr 17, 2024
* pokt/main:
  [TODOs] Add todos for future smt optimizations (#423)
  [Metrics] feat: Initial on-chain metrics implementation (#449)
  [Tooling] Add application stake/unstake/delegate logs (#482)
  [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472)
  [Docs] update supplier actor CLI section (#471)
  [Testing] chore: add make targets & update feature path logging (#470)
  [Metrics] Additional off-chain metrics (#468)
  Update test instructions pull_request_template.md (#473)
  [Tooling] Makefile checkers when starting localnet (#466)
  [LocalNet] Switch validator logs to json (#480)
  [Documentation] Refactor poktroll documentation so its easier to navigate (#474)
  [LocalNet] Add observability stack (#475)
@Olshansk Olshansk deleted the dk-localnet-grafana branch May 29, 2024 16:43
okdas added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infra Infra or tooling related improvements, additions or fixes tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants