Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic Series #154

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat: generic Series #154

merged 4 commits into from
Jul 25, 2024

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Jan 13, 2024 •
edited
Loading

Summary

image

@scarf005 scarf005 changed the title feat: generic series type feat: generic Series Jan 13, 2024
@scarf005 scarf005 marked this pull request as ready for review January 13, 2024 07:25
@universalmind303 universalmind303 self-requested a review January 17, 2024 06:30
@scarf005
Copy link
Contributor Author

@universalmind303 hi, could i learn why was this PR closed? would there be anything i could do to re-open this PR?

@Bidek56
Copy link
Collaborator

Bidek56 commented Jul 25, 2024

@scarf005 I think you may need to add Decimal DataType it was recently added to the main branch. Thx

@scarf005
Copy link
Contributor Author

@scarf005 I think you may need to add Decimal DataType it was recently added to the main branch. Thx

added Decimal in f5ff31c. please let me know if there's any issues.

@universalmind303 universalmind303 merged commit 95191df into pola-rs:main Jul 25, 2024
9 checks passed
@scarf005 scarf005 deleted the generic-series branch July 25, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scarf005 @Bidek56 @universalmind303