New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(partitionBy): set default value for `includeKey` #169

Merged

universalmind303 merged 1 commit into pola-rs:main from invakid404:main

Feb 23, 2024

Contributor

invakid404 commented Feb 21, 2024

This patch fixes an issue with partitionBy when you call it without any optional arguments.

Since includeKey has no default value, calling df.partitionBy('some_column') results in the following error:

Error: Failed to convert napi value into rust type `bool`
    at Proxy.partitionBy (node_modules/nodejs-polars/bin/dataframe.js:309:18)

This is caused by the fact that the value being passed for includeKey is undefined.

This patch reflects the default in the Rust version, which is includeKey = true.


          fix: set default value for includeKey

dead99a

universalmind303 approved these changes

View reviewed changes

universalmind303 merged commit 208000f into pola-rs:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet