feat: Support nulls_last
option in DataFrame#sort
#234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #235
The native binding for
DataFrame#sort
looks like:nodejs-polars/src/dataframe.rs
Lines 765 to 771 in 093d496
The LazyDataFrame variant also has the same shape.
But, the Javascript versions use a hardcoded
nulls_last
value oftrue
:nodejs-polars/polars/dataframe.ts
Line 2345 in 093d496
nodejs-polars/polars/lazy/dataframe.ts
Line 965 in 093d496
Additionally,
DataFrame#sort
has a minor argument bug:maintain_order
is not passed when using an options object. This bug is not present in the lazy variant.nodejs-polars/polars/dataframe.ts
Line 2337 in 093d496
So, we expose the option to the user here, and fix up the little bug.
This PR is technically breaking, since it changes the default value from
nulls_last
from TRUE to FALSE.This better matches the Rust & Python versions.