Skip to content

Replacing reverse with descending #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2024
Merged

Replacing reverse with descending #277

merged 5 commits into from
Oct 16, 2024

Conversation

Bidek56
Copy link
Collaborator

@Bidek56 Bidek56 commented Sep 21, 2024

Replacing reverse argument with descending to match py-polars and rs-polars

@Bidek56 Bidek56 self-assigned this Sep 21, 2024
@Bidek56 Bidek56 added the enhancement New feature or request label Sep 21, 2024
universalmind303
universalmind303 previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty big breaking change. We should instead deprecate the old parameters for at least one or two versions.

@universalmind303 universalmind303 merged commit 0fc9dcc into pola-rs:main Oct 16, 2024
12 checks passed
@Bidek56 Bidek56 deleted the removing-reverse-sort branch October 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees

@Bidek56 Bidek56

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bidek56 @universalmind303