-
-
Notifications
You must be signed in to change notification settings - Fork 54
feat: Adding lit_series func #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
so i think we need to be pretty careful about adding this in to the lazy dsl. The lazyframes will do broadcasting which can be very confusing and produce unexpected results. as such this is invalid. pl.DataFrame({"text": ["hello"]}).lazy().select("text", pl.Series("series",[1,2,3])).collectSync() but these are valid pl.DataFrame({"text": ["hello"]}).lazy().select(pl.Series("series",[1,2,3])).collectSync()
pl.DataFrame({"text": ["hello"]}).lazy().select("text", pl.Series("series",[1])).collectSync() If we want to introduce this, we'll need A LOT more tests to ensure broadcasting and various edge cases are consistent with rs and py polars. |
The cases shown above behave the same as in py polars. I will look for more test cases. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cases shown above behave the same as in py polars. I will look for more test cases. Thx
if it works in py-ppolars, thats good enough for me!
This PR fixes series struct tests, which is a big win! |
Adding lit_series func to lit Series into
LiteralValue
to close #351