chore(python): Add py-polars to Cargo workspace#12256
Merged
Conversation
github-actions
bot
added
internal
stinodego
requested review from
MarcoGorelli,
alexander-beedie,
orlp and
ritchie46
as code owners
ritchie46
approved these changes
Nov 5, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
py-polarscrate to the workspace as a non-default member. Benefits:targetfolder in the workspace - saves a whole bunch of space on my device and saves re-compiling things.The
Cargo.lockis now in the repo root, as well as theprofiledefinitions. These will still be picked up bymaturinand included in thesdist.For some context, the official recommendation for Rust projects is now to check in the lockfile, even for libraries:
rust-lang/cargo#12382