Skip to content

[Rust] DataFrame::get_column_names improvement#1949

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

[Rust] DataFrame::get_column_names improvement#1949
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 1, 2021

Following #1946, I would like to know if this kind of PR is legit.

@ghuls
Copy link
Collaborator

ghuls commented Dec 1, 2021

get_column_names should be a cheap operation which should not run on a threadpool (even with milion of columns 1 thread should still be very fast).

@ghost
Copy link
Author

ghost commented Dec 1, 2021

You're right, thanks.

I assume that the rest is OK. Don't hesitate to tell me if not please, I want to learn as much as posible.

@ghost ghost closed this Dec 1, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant