Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure list append uses correct dtype for scalar path #21926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcrumiller
Copy link
Contributor

Closes #21924.

Calling get_as_series downcasts the RHS scalar to the physical (i32 in the case of pl.Date) hence the error seen in the issue. This ensures it's properly recast to the logical.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (0aa889b) to head (3b1a194).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21926   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files        1628     1628           
  Lines      235118   235119    +1     
  Branches     2693     2693           
=======================================
+ Hits       190059   190068    +9     
+ Misses      44425    44417    -8     
  Partials      634      634           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcrumiller mcrumiller marked this pull request as ready for review March 26, 2025 03:38
@mcrumiller
Copy link
Contributor Author

Failed test is a worker node crash, unrelated to PR.

@ritchie46
Copy link
Member

I really think we should try to solve this in the type coercion. We made the mistake to do this in the kernels, but we should correct that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanicException when concatenating date and None in a list
2 participants