fix: Make sum on strings error in group_by context #25456
Merged
+37
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24659.
Calling
sum()on string columns ingroup_bycontext silently returned null instead of raising an error.Reproduction
Expected behavior (as in select context):
Cause
String type implements
sum_reduce()which correctly raises an error, but was missing anagg_sum()override in thePrivateSeriesimpl. The defaultagg_sum()implementation returns null for unsupported types, causing silent failure ingroup_byaggregations.Fix
Add
agg_sum()override for String type that raises the same error assum_reduce(), ensuring consistent behavior across select andgroup_bycontexts.