Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:修复路由规则针对老SDK的不兼容下发问题 #1362

Merged
merged 21 commits into from
Jul 1, 2024

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Jun 28, 2024

2024-06-28 23:56:16: =========TEST START==========
2024-06-29 02:02:57: =========TEST START==========
2024-06-29 02:30:43: =========TEST START==========
2024-06-29 11:54:46: =========TEST START==========
2024-06-29 12:24:58: =========TEST START==========
2024-06-29 12:36:19: =========TEST START==========
2024-06-29 14:50:16: =========TEST START==========
2024-06-29 17:45:04: =========TEST START==========
2024-06-29 20:35:50: =========TEST START==========
2024-06-30 13:55:23: =========TEST START==========
2024-06-30 14:58:14: =========TEST START==========
2024-06-30 17:03:09: =========TEST START==========
2024-06-30 18:45:04: =========TEST START==========
2024-06-30 18:54:20: =========TEST START==========
2024-06-30 21:55:22: =========TEST START==========
2024-07-01 09:07:55: =========TEST START==========
2024-07-01 10:22:49: =========TEST START==========
2024-07-01 12:02:49: =========TEST START==========

@chuntaojun chuntaojun closed this Jun 28, 2024
@chuntaojun chuntaojun reopened this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 69.00000% with 62 lines in your changes missing coverage. Please review.

Project coverage is 56.93%. Comparing base (0cc8c88) to head (7edb49e).

Files Patch % Lines
service/service.go 45.83% 13 Missing ⚠️
service/service_contract.go 20.00% 9 Missing and 3 partials ⚠️
service/instance.go 56.00% 11 Missing ⚠️
service/service_alias.go 33.33% 8 Missing ⚠️
cache/service/router_rule_bucket.go 16.66% 4 Missing and 1 partial ⚠️
apiserver/nacosserver/core/storage.go 0.00% 3 Missing ⚠️
config/client.go 50.00% 3 Missing ⚠️
service/default.go 88.00% 2 Missing and 1 partial ⚠️
cache/service/router_rule.go 33.33% 2 Missing ⚠️
plugin/healthchecker/leader/peer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   53.59%   56.93%   +3.33%     
==========================================
  Files         212      212              
  Lines       41472    33707    -7765     
==========================================
- Hits        22227    19190    -3037     
+ Misses      16614    11952    -4662     
+ Partials     2631     2565      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuntaojun chuntaojun changed the title Fix router rule fix:修复路由规则针对老SDK的不兼容下发问题 Jul 1, 2024
@chuntaojun chuntaojun merged commit 82eb9d0 into polarismesh:main Jul 1, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants