#4466 Enrich /webhooks/deliveries endpoint to include webhook endpoint schema #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smokyabdulrahman is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
smokyabdulrahman
changed the title
smokyabdulrahman
changed the title
smokyabdulrahman
commented
Jan 7, 2025
Comment on lines
+131
to
+133
| webhook_endpoint: WebhookEndpoint = Field( | ||
| description="The webhook endpoint called by this delivery." | ||
| ) |
There was a problem hiding this comment.
Is returning the whole schema too much?
Should I be adding a webhook_endpoint_url: EndpointUrl instead and load it like:
[WebhookDeliverySchema.model_validate({**result, "webhook_endpoint_url": result.webhook_endpoint.url) for result in results],
|
Thank you for raising this issue! I'll look into it and try to help if I can. |
Thank you so much. I've raised some questions on the original issue. So maybe after answering those questions, the solution might change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Addresses #4466
P.S.
I believe backend changes should be deployed first before deploying frontend ones, so there would be no downtime/errors window as a result of frontend updating first.