Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent DefaultValue from being set when the localStorage state does not contain the key. Fixes #26 #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

prevent DefaultValue from being set when the localStorage state does not contain the key. Fixes #26 #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17198f5
fix: prevent DefaultValue from being set when the localStorage state …
bartvanremortele Apr 16, 2021
a0821bf
fix: prevent DefaultValue from being set when the localStorage state …
bartvanremortele Apr 16, 2021
bf4894e
Merge branch 'fix/defaultvalue-getting-set' of github.com:bartvanremo…
bartvanremortele Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const recoilPersist = (
if (trigger === 'get') {
const state = getState()
if (typeof state.then === 'function') {
state.then((s) => {
state.then((s: any) => {
if (s.hasOwnProperty(node.key)) {
setSelf(s[node.key])
}
Expand All @@ -49,10 +49,9 @@ export const recoilPersist = (
if (
newValue !== null &&
newValue !== undefined &&
newValue instanceof DefaultValue &&
state.hasOwnProperty(node.key)
newValue instanceof DefaultValue
) {
delete state[node.key]
if (state.hasOwnProperty(node.key)) delete state[node.key]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these two construction are the same:

if (a && b) {
}

and

if (a) {
   if (b) {
   }
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not the same. If the state does not contain the node.key it will still persist the DefaultValue object because then it will fall in the else branch.

} else {
state[node.key] = newValue
}
Expand Down