Fix: Async getItem function may return null#59
Open
faiare wants to merge 1 commit intopolemius:masterfrom
Open
Fix: Async getItem function may return null#59faiare wants to merge 1 commit intopolemius:masterfrom
faiare wants to merge 1 commit intopolemius:masterfrom
Conversation
|
Can you provide a full example of this issue? |
polemius
force-pushed
the
master
branch
2 times, most recently
from
050c87f to
2f70d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getItem function in AsyncStorage may return null.
For this reason I have changed getItem to accept
Promise<string | null>and added handling if null is returned.