Skip to content

371 feature support title ii year range change #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ylyangtw
Copy link
Contributor

For testing, please run pdl-api dev branch and pdl-frontend locally. All Title-II pages should show 2014-2023.
image

@ylyangtw ylyangtw linked an issue Mar 28, 2025 that may be closed by this pull request
Copy link
Member

@sandeep-ps sandeep-ps Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussions in Slack conversation in the PDL channel and today's meeting, landing page year duration shouldn't be changed for now. Thanks.

@sandeep-ps
Copy link
Member

http://localhost:3000/title2
image

I think the Total Conservation Benefits page should use the /pdl/titles/title-ii/state-distribution API endpoint to render 2014-2023 data for Title-II. Currently, it's using the landing page map, which will only have the data for 2018-2022.

@sandeep-ps
Copy link
Member

CRP table has last updated month information. It needs to be updated the last updated month for the current data. We will need to ask Ryan about this.
image

Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Total Conservation Benefits map on http://localhost:3000/title2 needs to be updated to have 2014-2023 data. We cannot directly re-use the landing page map, as the data range is different.

I briefly checked the other pages, and the numbers look right. I will review it one more time after the current suggestions have been addressed.

@navarroc
Copy link
Contributor

I noticed when clicking among the different title II programs, sometimes they seem to get stuck loading the data (pending state), I'm not sure if this is an issue with my local machine or if it's something with querying the data. I just wanted to mention it so others could test it. I just click down the programs (letting them finish loading) and eventually it seems one gets stuck and a refresh of the page fixes it.

@ylyangtw
Copy link
Contributor Author

I noticed when clicking among the different title II programs, sometimes they seem to get stuck loading the data (pending state), I'm not sure if this is an issue with my local machine or if it's something with querying the data. I just wanted to mention it so others could test it. I just click down the programs (letting them finish loading) and eventually it seems one gets stuck and a refresh of the page fixes it.

I have this issue at my local as well, not just for this branch but for all frontend branches when connecting to local database. It will be resolved when I restart the local API.

@navarroc
Copy link
Contributor

It seems like maybe it's a threading issue. When I run the service using gunicorn so it has multiple workers, I don't see this issue on my local anymore. It's probably why we don't see it on dev, we have multiple workers to execute the API calls.

I noticed when clicking among the different title II programs, sometimes they seem to get stuck loading the data (pending state), I'm not sure if this is an issue with my local machine or if it's something with querying the data. I just wanted to mention it so others could test it. I just click down the programs (letting them finish loading) and eventually it seems one gets stuck and a refresh of the page fixes it.

I have this issue at my local as well, not just for this branch but for all frontend branches when connecting to local database. It will be resolved when I restart the local API.

@navarroc
Copy link
Contributor

CRP table has last updated month information. It needs to be updated the last updated month for the current data. We will need to ask Ryan about this. image

I still notice this issue, @ylyangtw, do we need to follow up with Ryan about this? Are you following up or is @sandeep-ps?

@navarroc
Copy link
Contributor

CRP table has last updated month information. It needs to be updated the last updated month for the current data. We will need to ask Ryan about this. image

I still notice this issue, @ylyangtw, do we need to follow up with Ryan about this? Are you following up or is @sandeep-ps?

I guess the question is, do we just need to update the date in the code (it's hard coded to Sep 2022) and do we know what date it should be now or is that what we need to ask Ryan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support title II year range change
3 participants