feat(supabase-postgres): image with -c fsync=off CMD for CI#3
Open
feat(supabase-postgres): image with -c fsync=off CMD for CI#3
-c fsync=off CMD for CI#3Conversation
lediur
changed the title
-c fsync=off CMD for CI
bchrobot
approved these changes
Jul 28, 2022
Member
bchrobot
left a comment
bchrobot
left a comment
There was a problem hiding this comment.
One small documentation change but otherwise looks good!
Comment on lines
+7
to
+8
| You need to log into Google Artifact Registry (GAR) before executing these commands. Follow the steps [here](https://cloud.google.com/artifact-registry/docs/docker/authentication#token). | ||
| If using the Access Token method, use the existing `gar-docker@assemble-services.iam.gserviceaccount.com` service account. |
Member
There was a problem hiding this comment.
I think the gcloud credential helper should be linked to by default and mentioned as the preferred method for building locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a copy of the
supabase-postgresDockerfile with-c fsync=offadded to the CMD.