Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows #123

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Update workflows #123

merged 4 commits into from
Mar 21, 2024

Conversation

guidoderooij
Copy link
Contributor

@guidoderooij guidoderooij commented Mar 21, 2024 •
edited
Loading

Some issues are reported on the workflows:

  • The workflows were executed on old Node versions. Solution is to only use Node version 18 and 20
  • Old versions of actions were used. Solution is to use the latest versions

After installing VSCode Github Actions extension it appeared that the logic to cache node_modules was incorrect so that is now also fixed (and verified)

@guidoderooij guidoderooij marked this pull request as ready for review March 21, 2024 12:29
@emielb emielb merged commit 6c4b7bd into main Mar 21, 2024
3 checks passed
@emielb emielb deleted the update-workflows branch March 21, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emielb emielb emielb approved these changes

@yasinkocak yasinkocak Awaiting requested review from yasinkocak yasinkocak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guidoderooij @emielb