-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use RuntimeGenesisConfig in genesis config presets #451
Open
dharjeezy
wants to merge
20
commits into
polkadot-fellows:main
Choose a base branch
from
dharjeezy:dami/use-runtime-genesis-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1ccb486
use RuntimeGenesisConfig in genesis config presets
dharjeezy 3f12e7c
fmt
dharjeezy 0e9243d
clippy fix
dharjeezy dcd050a
change log
dharjeezy fbf97c6
Update CHANGELOG.md
dharjeezy a09b416
revert
dharjeezy 83a9076
nit
dharjeezy 529a574
Merge remote-tracking branch 'origin/main' into dami/use-runtime-gene…
dharjeezy d6cca64
remove phantom fields in serde_jsons
dharjeezy 098bac9
fmt
dharjeezy ac021d9
clippy
dharjeezy 79a3d5b
fmt
dharjeezy 1354b29
empty
dharjeezy c3210cf
include polkadot xcm version
dharjeezy c4c5f35
Merge remote-tracking branch 'origin/main' into dami/use-runtime-gene…
dharjeezy 4140168
remove extra serde_json operation
dharjeezy 6736951
remove serde_json from toml
dharjeezy f725e7a
bring back remove_phantom_fields for now
dharjeezy ef78c8e
fmt
dharjeezy b83513a
fmt
dharjeezy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,41 +27,50 @@ fn asset_hub_kusama_genesis( | |
endowed_accounts: Vec<AccountId>, | ||
id: ParaId, | ||
) -> serde_json::Value { | ||
serde_json::json!({ | ||
"balances": BalancesConfig { | ||
let config = RuntimeGenesisConfig { | ||
system: Default::default(), | ||
balances: BalancesConfig { | ||
balances: endowed_accounts | ||
.iter() | ||
.cloned() | ||
.map(|k| (k, ASSET_HUB_KUSAMA_ED * 4096 * 4096)) | ||
.collect(), | ||
}, | ||
"parachainInfo": ParachainInfoConfig { | ||
parachain_id: id, | ||
..Default::default() | ||
}, | ||
"collatorSelection": CollatorSelectionConfig { | ||
transaction_payment: Default::default(), | ||
parachain_info: ParachainInfoConfig { parachain_id: id, ..Default::default() }, | ||
collator_selection: CollatorSelectionConfig { | ||
invulnerables: invulnerables.iter().cloned().map(|(acc, _)| acc).collect(), | ||
candidacy_bond: ASSET_HUB_KUSAMA_ED * 16, | ||
..Default::default() | ||
}, | ||
"session": SessionConfig { | ||
session: SessionConfig { | ||
keys: invulnerables | ||
.into_iter() | ||
.map(|(acc, aura)| { | ||
( | ||
acc.clone(), // account id | ||
acc, // validator id | ||
SessionKeys { aura }, // session keys | ||
acc.clone(), // account id | ||
acc, // validator id | ||
SessionKeys { aura }, // session keys | ||
) | ||
}) | ||
.collect(), | ||
}, | ||
"polkadotXcm": { | ||
"safeXcmVersion": Some(SAFE_XCM_VERSION), | ||
aura: Default::default(), | ||
aura_ext: Default::default(), | ||
polkadot_xcm: PolkadotXcmConfig { | ||
_config: Default::default(), | ||
safe_xcm_version: Some(SAFE_XCM_VERSION), | ||
}, | ||
// no need to pass anything to aura, in fact it will panic if we do. Session will take care | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment needs to go to line 58, at this position it does not make so much sense. |
||
// of this. `aura: Default::default()` | ||
}) | ||
assets: Default::default(), | ||
foreign_assets: Default::default(), | ||
parachain_system: Default::default(), | ||
vesting: Default::default(), | ||
pool_assets: Default::default(), | ||
}; | ||
|
||
serde_json::to_value(config).expect("Could not build genesis config.") | ||
} | ||
|
||
pub fn asset_hub_kusama_local_testnet_genesis(para_id: ParaId) -> serde_json::Value { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,41 +43,50 @@ fn asset_hub_polkadot_genesis( | |
endowed_accounts: Vec<AccountId>, | ||
id: ParaId, | ||
) -> serde_json::Value { | ||
serde_json::json!({ | ||
"balances": BalancesConfig { | ||
let config = RuntimeGenesisConfig { | ||
system: Default::default(), | ||
balances: BalancesConfig { | ||
balances: endowed_accounts | ||
.iter() | ||
.cloned() | ||
.map(|k| (k, ASSET_HUB_POLKADOT_ED * 4096 * 4096)) | ||
.collect(), | ||
}, | ||
"parachainInfo": ParachainInfoConfig { | ||
parachain_id: id, | ||
..Default::default() | ||
}, | ||
"collatorSelection": CollatorSelectionConfig { | ||
transaction_payment: Default::default(), | ||
parachain_info: ParachainInfoConfig { parachain_id: id, ..Default::default() }, | ||
collator_selection: CollatorSelectionConfig { | ||
invulnerables: invulnerables.iter().cloned().map(|(acc, _)| acc).collect(), | ||
candidacy_bond: ASSET_HUB_POLKADOT_ED * 16, | ||
..Default::default() | ||
}, | ||
"session": SessionConfig { | ||
session: SessionConfig { | ||
keys: invulnerables | ||
.into_iter() | ||
.map(|(acc, aura)| { | ||
( | ||
acc.clone(), // account id | ||
acc, // validator id | ||
SessionKeys { aura }, // session keys | ||
acc.clone(), // account id | ||
acc, // validator id | ||
SessionKeys { aura }, // session keys | ||
) | ||
}) | ||
.collect(), | ||
}, | ||
"polkadotXcm": { | ||
"safeXcmVersion": Some(SAFE_XCM_VERSION), | ||
aura: Default::default(), | ||
aura_ext: Default::default(), | ||
polkadot_xcm: PolkadotXcmConfig { | ||
_config: Default::default(), | ||
safe_xcm_version: Some(SAFE_XCM_VERSION), | ||
}, | ||
// no need to pass anything to aura, in fact it will panic if we do. Session will take care | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
// of this. `aura: Default::default()` | ||
}) | ||
assets: Default::default(), | ||
foreign_assets: Default::default(), | ||
parachain_system: Default::default(), | ||
vesting: Default::default(), | ||
pool_assets: Default::default(), | ||
}; | ||
|
||
serde_json::to_value(config).expect("Could not build genesis config.") | ||
} | ||
|
||
pub fn asset_hub_polkadot_local_testnet_genesis(para_id: ParaId) -> serde_json::Value { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the empty line was accidentally removed 😆 you need to bring it back (but empty, no whitespaces)