samouczek by nikitosych · Pull Request #441 · polonium14/polonium-station

nikitosych · 2026-01-31T23:54:22Z

aka "Wprowadzenie"

Informacje o PR

Niekompletna część systemu samouczka po stronie klienta. Infrastruktura po stronie klienta jest niby gotowa, sporo roboty jest z częścią serwerową.

Backend będzie opierał się na space-wizards#41602 (project batfly)
oraz na https://hedgedoc.spacestation14.com/kTStQRSmTP-FlQIF0dN4aQ?view

Refactor note: Cały kod został przeniesiony z Content.Shared do Content.Server.

Changelog
TODO

Media

TutorialTest:

…dzania

This reverts commit 0df7915.

- Zaktualizowano interfejs użytkownika BanPanel, dodając funkcję wyboru rundy i resetowania. - Zmodyfikowano polecenia związane z banowaniem, aby akceptowały i obsługiwały informacje o rundach. - Ulepszono metody banowania, aby przechowywać dane dotyczące rund. - Zaktualizowano pliki lokalizacyjne dla komunikatów związanych z rundami.

Copilot

Pull request overview

Copilot reviewed 52 out of 58 changed files in this pull request and generated 11 comments.

Copilot · 2026-02-12T15:22:43Z

Content.Server/GameTicking/Rules/Components/SolitarySpawningRuleComponent.cs

+{
+    /// <summary>
+    /// The list of spawn profiles available. The lobby can be configured to allow the player to pick one of the options.
+    /// If no player choice is made (or possible), the first prototoype will be chosen.


Typo in comment: prototoype -> prototype.

Suggested change

/// If no player choice is made (or possible), the first prototoype will be chosen.

/// If no player choice is made (or possible), the first prototype will be chosen.

Copilot · 2026-02-12T15:22:44Z

Content.Client/_Polonium/Introduction/Steps/ProceedPromptStep.cs

+        var name = $"{StepId}-fallback";
+        IntroUi.PlanOverlay(name);
+
+        var bubble = new IntroBubble(Loc.GetString("intro-proceed-prompt-message-fallback"))


The fallback overlay uses localization key intro-proceed-prompt-message-fallback, but the locale file defines intro-proceed-prompt-fallback-message. As-is, this will show a missing-loc placeholder; please align the key name between code and FTL.

Suggested change

var bubble = new IntroBubble(Loc.GetString("intro-proceed-prompt-message-fallback"))

var bubble = new IntroBubble(Loc.GetString("intro-proceed-prompt-fallback-message"))

Copilot · 2026-02-12T15:22:44Z

Resources/Locale/pl-PL/_Polonium/intro/intro.ftl

+intro-proceed-prompt-message-1 = Świetnie! Już nauczyłeś się niemal rzeczy!
+intro-welcome-begin-question-message = [bold]Czy chcesz teraz przejść do praktycznej części samouczka, gdzie będziesz mógł wypróbować swoje umiejętności na symulowanej stacji kosmicznej?[/bold]
+intro-proceed-prompt-agree-button = Tak!
+intro-proceed-prompt-disagree-button = Może później


This file defines intro-welcome-begin-question-message a second time for the proceed prompt (line 45), which will override the earlier welcome-step text and likely triggers FTL duplicate-key errors depending on loader settings. Please introduce a distinct key for the proceed-prompt question (and keep the original welcome key unique).

Copilot · 2026-02-12T15:22:45Z

Content.Client/_Polonium/Introduction/Steps/WelcomeStep.cs

+        IntroUi.PlanOverlay(StepId);
+        var welcomeBubble = new IntroBubble(
+            Loc.GetString("intro-welcome-message-1"),
+            Loc.GetString("intro-welcome-message-2"),
+            Loc.GetString("intro-welcome-message-3"))
+        {


The new client introduction step uses many intro-* localization keys (e.g. intro-welcome-message-1), but this PR doesn't add en-US translations for them. English clients will see raw key names; please add an en-US FTL for the introduction strings (similar to the pl-PL file).

Copilot · 2026-02-12T15:22:45Z

Resources/Prototypes/Roles/Jobs/Wildcards/trainee.yml

+  id: Trainee
+  name: job-name-trainee
+  description: job-description-trainee
+  playTimeTracker: JobTrainee


description: job-description-trainee is referenced by the new job, but there is no job-description-trainee entry in the pl-PL locale files. Add the missing pl-PL localization key (or point the job to an existing localized description key).

Copilot · 2026-02-12T15:22:46Z

Content.Client/_Polonium/Introduction/Steps/ProceedPromptStep.cs

+            Text = Loc.GetString("intro-welcome-begin-question-message"),
+            ModulateSelfOverride = Color.Black,
+            HorizontalAlignment = Control.HAlignment.Center,
+        };
+
+        var agreeButton = new Button
+        {
+            Text = Loc.GetString("intro-welcome-begin-agree-button"),
+            HorizontalAlignment = Control.HAlignment.Center,
+            Margin = new Thickness(0, 8, 0, 0),
+        };
+
+        var disagreeButton = new Button
+        {
+            Text = Loc.GetString("intro-welcome-begin-disagree-button"),


PromptOverlay() reuses the welcome prompt localization keys (intro-welcome-begin-...) for the practical/tutorial-server prompt. This makes the text/buttons incorrect and couples two unrelated steps; add dedicated proceed-prompt keys (question/agree/disagree) and update the code to use them.

Suggested change

Text = Loc.GetString("intro-welcome-begin-question-message"),

ModulateSelfOverride = Color.Black,

HorizontalAlignment = Control.HAlignment.Center,

};

var agreeButton = new Button

{

Text = Loc.GetString("intro-welcome-begin-agree-button"),

HorizontalAlignment = Control.HAlignment.Center,

Margin = new Thickness(0, 8, 0, 0),

};

var disagreeButton = new Button

{

Text = Loc.GetString("intro-welcome-begin-disagree-button"),

Text = Loc.GetString("intro-proceed-prompt-question-message"),

ModulateSelfOverride = Color.Black,

HorizontalAlignment = Control.HAlignment.Center,

};

var agreeButton = new Button

{

Text = Loc.GetString("intro-proceed-prompt-agree-button"),

HorizontalAlignment = Control.HAlignment.Center,

Margin = new Thickness(0, 8, 0, 0),

};

var disagreeButton = new Button

{

Text = Loc.GetString("intro-proceed-prompt-disagree-button"),

Copilot · 2026-02-12T15:22:46Z

Content.Client/_Polonium/Introduction/Steps/ProceedPromptStep.cs

+
+        IntroUi.PlanBubble(proceedBubble, HighlightOverlay.OverlayControlPosition.Center);


IntroUi.PlanBubble(proceedBubble, ...) is called twice for the same proceedBubble instance (once near the top of PromptOverlay() and again at the end). The second call will enqueue or attempt to re-place a control that was already added, leading to duplicate display or invalid parenting; remove the redundant call.

Suggested change

IntroUi.PlanBubble(proceedBubble, HighlightOverlay.OverlayControlPosition.Center);

Copilot · 2026-02-12T15:22:46Z

Content.Client/_Polonium/Introduction/UI/HighlightOverlay.cs

+        if (_ignoreHighlightClicks)
+        { // skoro nasza kontrolka jest w innej gałęzi drzewa UI,
+          // najlepszym sposobem ignorowania kliknięć to ustawienie filtra bezpośrednio na HighlightRegion
+            region.OriginalMouseFilter = control.MouseFilter;
+            control.MouseFilter = MouseFilterMode.Ignore;
+        }
+
+        if (region is { CloseOverlayOnClick: true, Control: Button button })
+        {
+            button.OnPressed += _ => DestroyOverlay();
+        }


When ignoreHighlightClicks is enabled, HighlightControl() sets the highlighted control's MouseFilter to Ignore (and optionally subscribes to button presses), but there is no guaranteed cleanup path that restores the original MouseFilter / unsubscribes handlers when the overlay is closed/orphaned. This can permanently break the underlying UI control and/or leak the overlay via event handlers. Ensure overlay teardown (e.g. DestroyOverlay, ExitedTree, Dispose, or IntroductionUIController.RemoveOverlay) always calls UnhighlightControl() and detaches any temporary event subscriptions.

Copilot · 2026-02-12T15:22:47Z

Content.Client/_Polonium/Introduction/UI/IntroBubble.xaml.cs

+        foreach (var text in texts)
+        {
+            var label = new RichTextLabel
+            {
+                Text = text,
+                Modulate = Color.Black,
+                Margin = new Thickness(0f, 5f),
+            };
+
+            BubbleMain.AddChild(label);
+        }


This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.

Content.Server/GameTicking/Rules/SolitarySpawningRuleSystem.cs

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…//github.com/polonium14/polonium-station/issues/41588)) gameticker dospawn

nikitosych and others added 30 commits November 15, 2025 03:41

Skrypt publikacji jest teraz powiązany z CDN Polonium

52491a0

Utworzono workflow do publikowania serwera

8980909

Naprawiono odniesienie do repozytorium w gałęzi głównej podczas spraw…

44c1992

…dzania

Dodano rejestrowanie wersji silnika w funkcji get_engine_version

c9807b2

Dodano rejestrowanie długości tokenu

bfec232

Dodano automatyczną synchronizację z głównym repozytorium

df33633

Dodano kroki do ustawienia tożsamości git oraz uprawnienia dla action

ae8f4a6

Poprawiono obsługę błędów

209409f

Zmiana kolejności kroków

4e6523b

Zmieniono gałąź na master w kroku Push changes (o boże...)

e120e19

Tryby

dd70aab

mapy

7854725

usunięto dm z puli

0df7915

Revert "usunięto dm z puli"

30f54e5

This reverts commit 0df7915.

Proba usunięcia wymagań do zawodów. Czy zadziała?

d99e4b2

Wyzerowano wszystkie wymagania do ról

f5dd306

Usunięto duplikat

2f287b8

Dodano folder z workflows do gitignore

dff906f

Przywracanie workflows

609a55b

Zaktualizowano workflow

76e5a01

Zaktualizowano workflow

8eca995

Dodano integrację webhooków Discord dla powiadomień o banach

0eaba7d

poprawiono obsługę webhooków Discord

1f210ca

Błądzik poprawiony

038e270

Błądzik poprawiony

829b3b5

changelog

c8e777f

worflow for cl only

c4f9e14

workflow update

c53db89

AGPL -> MIT

cd48f6c

Copilot started reviewing on behalf of nikitosych February 12, 2026 15:00 View session

chore: Automatically update REUSE headers

9ae1c0d

Copilot AI reviewed Feb 12, 2026

View reviewed changes

nikitosych added 2 commits February 12, 2026 16:33

feat: Update solitary server configuration with new game settings

cc13718

Merge branch 'master' into intro

575adc1

Copilot AI review requested due to automatic review settings February 28, 2026 14:59

Copilot started reviewing on behalf of nikitosych February 28, 2026 14:59 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Make gameticker spawn code more modular ([space-wizards#41588](https:…

bdd43e2

…//github.com/polonium14/polonium-station/issues/41588)) gameticker dospawn

nikitosych force-pushed the intro branch from 8335796 to bdd43e2 Compare February 28, 2026 17:14

Polonium-bot and others added 9 commits February 28, 2026 17:16

chore: Automatically update REUSE headers

3326ce1

fix EntryPoint

8029c04

fix ftl

f3dab57

refactor

4c85805

fix entrypoint

93cad42

config update and map removal

e5ac25d

kolejny fix entrypoint

3f359b7

mapa (wip)

a5328fd

sadsdasdasd

942601b

nikitosych added this to the Next Stage milestone Mar 6, 2026

nikitosych added 2 commits March 7, 2026 00:44

Postęp mapy

76e5ce1

Postęp mapy

3f1d57f

nikitosych added the P2: Podwyższony Priorytet: Element może wymagać większej uwagi ze strony maintainerów. label Mar 9, 2026

Postęp mapy

6321b51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

samouczek#441

samouczek#441
nikitosych wants to merge 126 commits intopolonium14:masterfrom
nikitosych:intro

nikitosych commented Jan 31, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	/// If no player choice is made (or possible), the first prototoype will be chosen.
	/// If no player choice is made (or possible), the first prototype will be chosen.

	var bubble = new IntroBubble(Loc.GetString("intro-proceed-prompt-message-fallback"))
	var bubble = new IntroBubble(Loc.GetString("intro-proceed-prompt-fallback-message"))


		IntroUi.PlanBubble(proceedBubble, HighlightOverlay.OverlayControlPosition.Center);

Uh oh!

Conversation

nikitosych commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Informacje o PR

Media

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikitosych commented Jan 31, 2026 •

edited

Loading