fix: make flow.functions.X clickable by fixing path resolution and bypassing __getattr__ - #22
Merged
Merged
Conversation
Previously, only `flow.functions.func_name` and `conv.functions.func_name` were clickable. Now `flow.func_name` and `conv.func_name` also navigate to the function definition file, with matching hover and find-references support. Known runtime attributes (e.g. flow.goto_step, conv.say) are excluded so they continue to show their runtime tooltips. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Valid PR Title
This PR will trigger a patch release when merged to
|
…lick DocumentLinks take priority over definition providers on Ctrl+Click. This means clicking flow.func_name or conv.func_name navigates directly to the function file instead of showing Pylance's __getattr__ result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Revert the direct flow.X / conv.X changes — the actual patterns are flow.functions.X and conv.functions.X. The DocumentLinkProvider now creates links for these qualified patterns so Ctrl+Click navigates directly to the function file without showing Pylance's __getattr__. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The resolver was looking for flow functions at project_root/functions/flow_name/func.py but the actual structure is project_root/flows/flow_name/functions/func.py. Now uses the flow_config.yaml ancestor to locate the flow directory and looks in its functions/ subdirectory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhandal09
changed the title
dhandal09
changed the title
nika-karsanova
approved these changes
Jun 12, 2026
poly-adk-bot Bot
pushed a commit
that referenced
this pull request
Jun 12, 2026
## [1.2.2](v1.2.1...v1.2.2) (2026-06-12) ### Bug Fixes * make flow.functions.X clickable by fixing path resolution and bypassing __getattr__ ([#22](#22)) ([0c14c53](0c14c53))
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project/functions/flow_name/func.py, now correctly resolves toproject/flows/flow_name/functions/func.pyusing theflow_config.yamlancestorDocumentLinkProviderforconv.functions.X/flow.functions.Xcalls so Ctrl+Click navigates directly to the function file, bypassing Pylance's__getattr__definitionTest plan
flow.functions.some_functionnavigates toflows/<flow>/functions/some_function.pyconv.functions.some_functionnavigates tofunctions/some_function.py__getattr__no longer appears as a navigation target🤖 Generated with Claude Code