feat(audio): Allow label-volume in muted format #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until c552df3 ("fix: Modules did not validate tags used in formats") it was possible to use the volume label in the muted format. This made sense as the volume level can change while muted and it allowed for example following formats: format-volume = "<ramp-volume> <label-volume> " format-muted = <label-muted> (<label-volume>) Add label-volume to the format-muted allowlist to re-enable this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until c552df3 ("fix: Modules did not validate tags used in formats") it was possible to use the volume label in the muted format. This made sense as the volume level can change while muted and it allowed for example following formats:
Add label-volume to the format-muted allowlist to re-enable this feature.
What type of PR is this? (check all applicable)
Description
Related Issues & Documents
Documentation (check all applicable)
Add
<label-volume>to the comment describing the available tags offormat-mutedin both the alsa and the pulseaudio wiki page.