Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time-smoother #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

time-smoother #8

wants to merge 2 commits into from

Conversation

hypotrochoid
Copy link

No description provided.

@hypotrochoid hypotrochoid requested a review from qrpike June 17, 2021 18:58
cpustejovsky
cpustejovsky reviewed Nov 10, 2022
View reviewed changes
time_smoother/time.go

syncInterval uint64

stop chan bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If stop is only acting as a signal, an empty struct would be more memory efficient to use instead of a bool.

Here's a blog post by Dave Cheney explaining why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpustejovsky cpustejovsky cpustejovsky left review comments

@qrpike qrpike Awaiting requested review from qrpike

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypotrochoid @cpustejovsky