Skip to content

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Sep 15, 2025

Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 625876e
🔍 Latest deploy log https://app.netlify.com/projects/pomerium-docs/deploys/68d56bd40a0d3900074442fa
😎 Deploy Preview https://deploy-preview-1993--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@alexandreLamarre alexandreLamarre marked this pull request as ready for review September 15, 2025 21:25
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner September 15, 2025 21:25
@alexandreLamarre alexandreLamarre requested review from kenjenkins and removed request for a team September 15, 2025 21:25

In Pomerium, these health checks will report on the status of:

- Readiness and health of the embedded envoy instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Readiness and health of the embedded envoy instance
- Readiness and health of the embedded Envoy instance


### Liveness

The `/healthz` endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing liveness content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I accidentally git stashed those changes.


### Filters

Unlike HTTP probes, the CLI provides additional flexibility through exclude filters, which let you ignore specific internal conditions reported by Pomerium when evaluating health.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a check definition section with short descriptions of what each of these checks covers, so they can figure out what they might want to filter out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably a good idea to do that, although they're internal checks so may not make intuitive sense to users, so let me take some time to think about the best way to document those

@rjbeers rjbeers merged commit d628722 into main Oct 2, 2025
9 checks passed
@rjbeers rjbeers deleted the health-checks branch October 2, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants