fix: user and assistant messages now properly sent to chat API #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mcp-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the chat component where user and assistant messages were not being properly synchronized with the chat API's message state. The fix ensures that both streaming assistant responses and user messages are correctly maintained in the chat history.
Key changes:
- Added proper message synchronization logic using
useEffectto merge assistant messages from the stream buffer into the main messages array - Implemented duplicate message prevention using a ref-based tracking system
- Enhanced the render logic to display both persisted messages and streaming content
nickytonline
changed the title
auto-merge was automatically disabled
October 12, 2025 03:17
Pull request was converted to draft
wasaga
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where user and assistant messages were not being properly sent to the chat API, ensuring correct message handling and conversation flow. Prior to this fix, since only user messages were sent to the chat api, the llm answered previously answered questions.
Related Issues
Fixes #166