-
Notifications
You must be signed in to change notification settings - Fork 151
breaking: update fontdb, rustybuzz, and ttf-parser #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Might be worth updating this PR to use |
96e5c8e to
a0a03fc
Compare
Sorry for the delay, had a busy week. Done :) |
fec03d3 to
d2ab394
Compare
|
|
|
fontdb 0.23 is now available. Is there a chance that this could be revisited? This would allow fonts to load properly on FreeBSD. |
|
@jcdickinson Are you able to make the changes requested by @MoSal and perhaps bump fontdb to v0.23.0 |
d2ab394 to
89eae31
Compare
89eae31 to
9a3edca
Compare
|
Upped fontdb and rustybuzz. ttf-parser changed to match the one used by fontdb. Note that this will need to be coordinated with cosmic-ui, I will open a PR there. |
|
Hi @MoSal. Would you be willing to review this? |
fontdb 0.21 is an update that resolves the symlink regression.
I have tested this update on my machine (as the author), which has heavily symlinked fonts due to Nix/home-manager usage.
This technically qualifies as a breaking change (it isn't semantically), because a dep is being bumped in an incompatible way. Downstream crates will probably continue to build, but will silently include another version of fontdb.
Subsequent PRs:
resvgto0.45iced-rs/iced#2846