Revert "Fix Noto Color Emoji font fallback order for Unix"
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 66288ab. Note that putting "Noto Color Emoji" anywhere lower (even just below "DejaVu Sans") creates issue described in pop-os#327 Putting it above "Noto Sans" breaks text rendering completely. With the commit reverted I cannot reproduce the original issue pop-os#68 the commit 66288ab was supposed to fix.
Author
|
For posterity here are some screenshots... With this PR: When "Noto Color Emoji" is first in the array (above "Noto Sans"), text rendering breaks completely, but emojis work: When "Noto Color Emoji" is just below "DejaVu Sans", text rendering does not display emojis properly: |
Member
|
Perhaps @hecrj can check if this works okay on their system? |
Contributor
|
@jackpot51 Just tried it and I have the same issues:
I don't have Noto Sans installed, so it's choosing the emoji font as fallback for many glyphs. I don't think an emoji font should be that high in the fallback sequence. |
Contributor
|
I believe a proper fix would be to have a separate emoji fallback list and have some kind of emoji detection during font selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 66288ab.
Fixes #327
Note that putting "Noto Color Emoji" anywhere lower (even just below "DejaVu Sans") creates issue described in #327
Putting it above "Noto Sans" breaks text rendering completely.
With the commit reverted I cannot reproduce the original issue #68 the commit 66288ab was supposed to fix.