-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alongside Option #173
base: master
Are you sure you want to change the base?
Alongside Option #173
Conversation
While I have yet to look at this specific pr, the following are notes from having looked at #157 yesterday:
|
@brs17 I've been thinking about how to handle this. The live disk can also be the recovery partition, which does want to be able to install to itself. I think it just needs a check for the recovery.conf file, and hiding it if not found. |
Another thing I noticed is the visibility of "Alongside OS" in the recovery partition. It doesn't seem to really make sense to have that as a visible option. So potentially you only need to look for recovery.conf to not show the functionality at all. |
86d04e1
to
1ecbb12
Compare
New changes:
Requires distinst |
Still looking into Windows 10 resizing issues. Resizing with GParted works, but resizing with distinst does not. I've been comparing what GParted and distinst are doing differently, and I am running out of ideas on the cause. Things which
As far as I can tell, distinst and gparted are doing the exact same actions, even in the way that the partition is recreated with an Some notes: I can verify that the boot sector (first sector of the NTFS partition) remains valid after the resize. The "Hidden Sectors" count is the same value before and after the resize, which is the first four bytes starting from ntfsresize also reports that the partition is fine, so there doesn't seem to be a partitioning problem. All of the files are accessible when mounting the partition in Linux or in the recovery mode. So, there must be some extra step in the gparted code that's not easily found by grepping for references to ntfs. |
src/Views/ResizeView.vala
Outdated
"%.1f GiB".printf ((double) (our_os_size - minimum) / SECTORS_AS_GIB) | ||
)); | ||
|
||
other_os_size_label.label = _("""%s <span alpha="67%">(%s Free)</span>""".printf ( | ||
"%.1f GiB".printf ((double) other_os_size / SECTORS_AS_GIB), | ||
other_os_size_label.label = _("""<span alpha="67%">%s Free</span>""".printf ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use the GTK-standard "dim-label" style constant here now.
a866dc5
to
d8a21ac
Compare
d8a21ac
to
b1081ee
Compare
Based on the refresh-option PR, with the alongside option re-enabled.
In a VM with Windows installed:
Resizing Windows: