chore(deps): bump cryptography from 46.0.7 to 50.0.0 in /backend - #248
chore(deps): bump cryptography from 46.0.7 to 50.0.0 in /backend#248dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [cryptography](https://github.com/pyca/cryptography) from 46.0.7 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@46.0.7...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LlamaPReview — No blocking issues found
Approve: bumping cryptography to 50.0.0 is safe for this repo because no first-party code uses it, only transitive deps aiortc and pyopenssl do.
1 non-blocking finding retained — highest: No first-party cryptography usage makes major-version bump safe.
Change flow
The install-path fork determines whether this pin swap has any runtime effect — the core install decision this PR touches.
sequenceDiagram
participant Dev as Developer
participant Repo as Repo (pyproject.toml, uv.lock)
participant Export as uv export
participant CI as CI/Prod install
Dev->>Repo: Declare deps & lock
Repo->>Export: uv export generates requirements.txt
note over Export: PR change — cryptography pinned 50.0.0
alt Install from requirements.txt
Export->>CI: Install cryptography==50.0.0
else Install via uv sync
Repo->>CI: Use uv.lock resolution<br/>may still be old pin
end
Review details and evidence
| Priority | File | Finding | Evidence |
|---|---|---|---|
| P2 | backend/requirements.txt |
No first-party cryptography usage makes major-version bump safe. | confirmed |
Material unknowns
- Whether backend/uv.lock resolves cryptography at 50.0.0 and whether production installs from requirements.txt or via uv sync. If uv.lock pins below 50.0.0 and installs use uv sync, this PR has no effect; a future uv export regeneration would overwrite the pin. If production installs from requirements.txt, the bump applies directly.
- Check: Check the cryptography entry in backend/uv.lock and the install command used in CI/production; if the lockfile is below 50.0.0, update pyproject.toml/uv.lock and regenerate the export.
- cryptography 50.0.0's minimum Python version relative to the project's >=3.11 floor. If 50.0.0 raised its Python floor above 3.11, installs would fail; Deep assessed this as minimal risk because the floor is well above historical values.
- Check: Run a one-time install evaluation (pip install -r backend/requirements.txt or uv export) to confirm compatibility.
LlamaPReview checks
- Inspected matching PR-head repository snippets in
backend/requirements.txt. - Read bounded PR-head context from
backend/requirements.txt. - Read bounded PR-head context from
backend/pyproject.toml.
Automated review by LlamaPReview · Free for public open-source projects.
| --hash=sha256:fcd8eac50d9138c1d7fc53a653ba60a2bee81a505f9f8850b6b2888555a45d0e \ | ||
| --hash=sha256:fdd1736fed309b4300346f88f74cd120c27c56852c3838cab416e7a166f67298 \ | ||
| --hash=sha256:ffca7aa1d00cf7d6469b988c581598f2259e46215e0140af408966a24cf086ce | ||
| cryptography==50.0.0 \ |
There was a problem hiding this comment.
P2 | Confidence: Medium
The change is a single pin swap in a generated requirements file. Deep found no first-party code using cryptography, cryptography.hazmat, or pkcs7 — the only references are the transitive via-lines aiortc and pyopenssl. Therefore the announced breaking changes (PKCS#7 fix, FFDH deprecation, stricter parsing) have no observed reachable path. CI is green on deploy checks; CodeQL is neutral with no findings. The residual risks are unobserved transitive compatibility and install-path durability.
Owner action: Optional: run a backend smoke test of the WebRTC/DTLS path to confirm aiortc works with the new pin.
Evidence: matching repository snippets in backend/requirements.txt; bounded PR-head context from backend/requirements.txt; bounded PR-head context from backend/pyproject.toml.
Bumps cryptography from 46.0.7 to 50.0.0.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
dcb7050Prepare for 50.0.0 release (#15372)53fccd9Don't leak how PKCS#7 encryptedKey decryption failed (#15369)d472f97Addfrom __future__ import annotationsto all src/ Python files (#15371)908773dBump downstream dependencies in CI (#15368)2cc07ccBump BoringSSL, OpenSSL, AWS-LC in CI (#15367)c94ede9chore(deps): bump ruff from 0.16.0 to 0.16.1 (#15366)67a8308chore(deps): bump virtualenv from 21.7.0 to 21.7.1 (#15365)95018ffRelease the GIL in one-shot AEAD encrypt/decrypt (#15361)6954733Release the GIL during DH and DSA parameter generation (#15364)6893b94Import _serialization instead of serialization in x509/extensions (#15363)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.