Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaquita genetic map snag #111

Closed
silastittes opened this issue May 9, 2024 · 9 comments
Closed

Vaquita genetic map snag #111

silastittes opened this issue May 9, 2024 · 9 comments

Comments

@silastittes
Copy link
Contributor

The pipeline as written seems to require a genetic map at various places.
I'm getting the following error here :

ERROR:snakemake.logging:RuleException:
ValueError in file analysis2/workflows/n_t.snake, line 488:
GeneticMap 'PhoSin/None' not in catalog ()

I think the issue is most salient in this function, where various aspects of the code depend on GeneticMap methods.

I'm wondering if folks more familiar with stdpopsim can help me navigate this.
Maybe a silly solution, but maybe an update to the catalog code that makes a constant genetic map file that can be downloaded so that the GeneticMap methods are still available? Maybe this is already the case and I just need to adjust how to initial the pipeline?
Thanks for thoughts!

@andrewkern
Copy link
Member

andrewkern commented May 9, 2024

tagging @petrelharp here -- is there no PhoSin map? maybe there is a map that needs to be uploaded to AWS?

@petrelharp
Copy link
Contributor

No, there is no genetic map (perhaps unsurprisingly?)
Screenshot from 2024-05-09 17-14-48

Sounds like the pipeline needs to be modified - there is no reason we need to use a map?

@silastittes
Copy link
Contributor Author

I don’t think we need one for the aims of the manuscript. Could we make a “fake” constant one for Vaquita for this project ? My initial impression is it will take a lot of refactoring to make the pipeline work without one, but that may reflect my lack of familiarity with the code bases.

@petrelharp
Copy link
Contributor

Well, probably? That sounds like the long way round but then I'm not familiar with the pipeline. The error you got could be fixed relatively easily with some special-case logic, but I haven't seen how often this comes up?

@silastittes
Copy link
Contributor Author

Yeah, it may be a smaller issue than I initially thought. I’ll try making some minor edits and see if I can get it working without a genetic map.

@silastittes
Copy link
Contributor Author

Ok, I think I got this sorted out -- PR forthcoming. MSMC is failing to converge, but maybe that won't be an issue for the production pipeline?

@andrewkern
Copy link
Member

guessing MSMC isn't converging in the tiny config cause of too few sites?

@silastittes
Copy link
Contributor Author

I think so too. Giving both species on more clean run with tiny config to make sure everything is square then I’ll PR the update.

@silastittes
Copy link
Contributor Author

fixed with #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants