-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vaquita genetic map snag #111
Comments
tagging @petrelharp here -- is there no PhoSin map? maybe there is a map that needs to be uploaded to AWS? |
I don’t think we need one for the aims of the manuscript. Could we make a “fake” constant one for Vaquita for this project ? My initial impression is it will take a lot of refactoring to make the pipeline work without one, but that may reflect my lack of familiarity with the code bases. |
Well, probably? That sounds like the long way round but then I'm not familiar with the pipeline. The error you got could be fixed relatively easily with some special-case logic, but I haven't seen how often this comes up? |
Yeah, it may be a smaller issue than I initially thought. I’ll try making some minor edits and see if I can get it working without a genetic map. |
Ok, I think I got this sorted out -- PR forthcoming. MSMC is failing to converge, but maybe that won't be an issue for the production pipeline? |
guessing MSMC isn't converging in the tiny config cause of too few sites? |
I think so too. Giving both species on more clean run with tiny config to make sure everything is square then I’ll PR the update. |
fixed with #112 |
The pipeline as written seems to require a genetic map at various places.
I'm getting the following error here :
I think the issue is most salient in this function, where various aspects of the code depend on GeneticMap methods.
I'm wondering if folks more familiar with stdpopsim can help me navigate this.
Maybe a silly solution, but maybe an update to the catalog code that makes a constant genetic map file that can be downloaded so that the GeneticMap methods are still available? Maybe this is already the case and I just need to adjust how to initial the pipeline?
Thanks for thoughts!
The text was updated successfully, but these errors were encountered: