updates to get PhoSin and HomSap working #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request closes #111 |
silastittes
commented
May 10, 2024
There was a problem hiding this comment.
This is another spot where I hit a snag that also relates to not having a genetic map. Since a lot of places expected a non-empty mask file to exist, I figured this would be simpler and be would unlikely impact the results. I admit it's a little hacky though.
silastittes
commented
May 10, 2024
There was a problem hiding this comment.
Migrated Chris Smith's poster figs to here. Still some work needed, but will push figures from here to manuscript soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary issue was that Vaquita does not have a genetic map. I think the solution here is the simplest fix, but if anyone has better suggestions please don't hesitate!
Other issue was smcpp install rule wasn't working. Luckily there is a pip install option that seems to work. I've circumvented the install rule, but kept to rule in the code.