Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 2-epoch demographic model for Vaquita #1526

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

igronau
Copy link
Contributor

@igronau igronau commented Oct 12, 2023

I implemented the 2-epoch demographic model from Robinson et al. (2022), which is what we plan on using for the simulations in the selection paper (for DFE inference). See #1508

@igronau igronau mentioned this pull request Oct 12, 2023
@petrelharp
Copy link
Contributor

Awesome!

I've tried bumping the cache number to get the tests to run?!?!

Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one minor wording fix!

@petrelharp
Copy link
Contributor

Closes #1508.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b185585) 99.85% compared to head (fc42476) 99.85%.
Report is 12 commits behind head on main.

❗ Current head fc42476 differs from pull request most recent head 60d89cc. Consider uploading reports for the commit 60d89cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1526   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         125      126    +1     
  Lines        4217     4228   +11     
  Branches      588      588           
=======================================
+ Hits         4211     4222   +11     
  Misses          3        3           
  Partials        3        3           
Files Coverage Δ
stdpopsim/catalog/PhoSin/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/PhoSin/demographic_models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor

These tests run fine locally for me; I will merge this without CI passing, pending #1529 .

@petrelharp petrelharp merged commit bd05755 into popsim-consortium:main Oct 17, 2023
3 of 9 checks passed
@petrelharp
Copy link
Contributor

Can you open the QC issue, @igronau ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants