Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sweep API and extended events from stdpopsim.ext to stdpopsim #1569

Merged
merged 5 commits into from
Jul 6, 2024

Conversation

nspope
Copy link
Collaborator

@nspope nspope commented Jul 5, 2024

No description provided.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (e52b33e) to head (5ae0d02).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   99.83%   99.83%   -0.01%     
==========================================
  Files         131      130       -1     
  Lines        4340     4339       -1     
  Branches      595      595              
==========================================
- Hits         4333     4332       -1     
  Misses          3        3              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nspope
Copy link
Collaborator Author

nspope commented Jul 5, 2024

Does the added doc blurb look OK here @petrelharp ? I added in the API for extended events, but maybe we don't actually want these as they're not mentioned anywhere else in the docs (e.g. we could just include selective_sweep in api.rst)

@nspope nspope requested a review from petrelharp July 5, 2024 21:54
@petrelharp
Copy link
Contributor

I'm going to merge, and will consider the docs later.

@petrelharp petrelharp merged commit 09f97ea into popsim-consortium:main Jul 6, 2024
11 checks passed
Copy link
Contributor

@petrelharp petrelharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants