various fixes after msprime api updates #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh good, I see validation is part of the CI checks. Fixing linting, etc. now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 130 130
Lines 4354 4354
Branches 597 597
=======================================
Hits 4346 4346
Misses 3 3
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
Looks like this is failing for the same reasons as main? This should be good now. |
petrelharp
reviewed
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the pairs run successfully and generate output now. Might be worth a spot check or two by someone else that a. knows what the previous output looked like b. has a different version of libraries installed (I'm using the analysis2 conda env).
Closes #786