"Safer" State #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom init and deinit, respectively
pragmatrix
force-pushed
the
safer-state
branch
from
c2fc209 to
af0c342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stateis unsafe in respect to hot reloading new versions of the dynamic library that is being watched, but it does not have to unsafe when initialized or dropped. With this PR merged,Statecan be initialized by returning it from theinit()function and dropped (implicitly) in thedeinit()function.Context was that I never was sure what kind of values were safe to put into State, sometimes putting another complex Rust value worked, and sometimes an
Option<Box<T>>was needed to avoid crashes at initialization time.