Fix static mut issues with routines
#677
Conversation
It creates references to `static mut`
| // Now unwrap the definitions from our thread-safe type | ||
| let unwrapped: Vec<R_CallMethodDef> = R_ROUTINES | ||
| .lock() | ||
| .unwrap() | ||
| .iter() | ||
| .map(|def| def.inner) | ||
| .collect(); |
There was a problem hiding this comment.
I'm fairly surprised you dont get a warning about "dropping temporary value" since no one is holding the lock in a local variable here. I seem to get that all the time when doing stuff like this.
| name: std::ptr::null(), | ||
| fun: None, | ||
| numArgs: 0, | ||
| }); | ||
|
|
||
| // Now unwrap the definitions from our thread-safe type | ||
| let unwrapped: Vec<R_CallMethodDef> = R_ROUTINES |
There was a problem hiding this comment.
| let unwrapped: Vec<R_CallMethodDef> = R_ROUTINES | |
| let routines: Vec<R_CallMethodDef> = R_ROUTINES |
| R_registerRoutines( | ||
| info, | ||
| std::ptr::null(), | ||
| R_ROUTINES.as_ptr(), | ||
| unwrapped.as_ptr(), |
There was a problem hiding this comment.
| unwrapped.as_ptr(), | |
| routines.as_ptr(), |
| unsafe impl Send for CallMethodDef {} | ||
| unsafe impl Sync for CallMethodDef {} | ||
|
|
||
| static R_ROUTINES: Mutex<Vec<CallMethodDef>> = Mutex::new(vec![]); |
There was a problem hiding this comment.
Nice I also tried this when fiddling with this one last week but got stuck on the R_CallMethodDef not being send+sync problem
| unsafe impl Send for CallMethodDef {} | ||
| unsafe impl Sync for CallMethodDef {} |
There was a problem hiding this comment.
I think my main comment is that #[harp::register] is pretty freaking magical. It generates some code that runs at application startup time in an OS specific way.
I guess we can assume that code is always run on a single thread? I have no idea how startup code gets run on a per OS basis. I just want to make sure this doesn't screw us up.
Closes #661.
Ideally
R_ROUTINESwould be thread-local but that's currently inconvenient in unit tests.