Skip to content

Conversation

@toph-allen
Copy link
Collaborator

@toph-allen toph-allen commented Oct 2, 2025

Intent

Modify Runtime Version Scanner to use content search via connectapi's search_content()

This is just a draft — this implementation changes functionality relative to the base version. Most specifically, it only displays content you own, it doesn't display content you collaborate on.

Approach

  • Use content search's filtering capabilities where possible
    • Always filtering for owned content
    • Pass in the selected content type, convert that to a string representing app modes, and include that in the query string
  • Convert to data frame shortly after fetching — this allows it to slot into the existing functionality quickly. This may be changed in a future version.

Notes

Most of my notes from this have been captured as issues on connectapi or Connect itself.

Performance is mostly better than base get_content() / GET v1/content against our dev server — the former fetches all content and converts to a data frame / parses (which is costly), and then filters against that. Performance was worse if I ran into scenarios that require pagination (not really an issue here because users rarely have more than 500 pieces of content, but may be an issue if we move forward with allowing admins to view all content.)

@toph-allen toph-allen marked this pull request as ready for review October 8, 2025 16:07
Base automatically changed from toph/rvs-organize-like-r-package to main October 8, 2025 17:51
@toph-allen toph-allen requested review from jonkeane and karawoo October 8, 2025 19:15
@toph-allen toph-allen requested a review from karawoo October 9, 2025 18:01
Copy link
Contributor

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@toph-allen toph-allen merged commit 6919067 into main Oct 9, 2025
21 checks passed
@toph-allen toph-allen deleted the toph/rvs-use-search-content branch October 9, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants