-
Notifications
You must be signed in to change notification settings - Fork 3
feat: runtime version scanner: adopt content search #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-dev/connect-extensions into toph/rvs-use-search-content
Co-authored-by: Kara Woo <[email protected]>
Co-authored-by: Kara Woo <[email protected]>
…ike-r-package' into toph/rvs-organize-like-r-package
karawoo
requested changes
Oct 8, 2025
Co-authored-by: Kara Woo <[email protected]>
…t-dev/connect-extensions into toph/rvs-use-search-content # Conflicts: # extensions/runtime-version-scanner/R/fetch_content.R
karawoo
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Modify Runtime Version Scanner to use content search via
connectapi'ssearch_content()This is just a draft — this implementation changes functionality relative to the base version. Most specifically, it only displays content you own, it doesn't display content you collaborate on.
Approach
Notes
Most of my notes from this have been captured as issues on
connectapior Connect itself.Performance is mostly better than base
get_content()/GET v1/contentagainst our dev server — the former fetches all content and converts to a data frame / parses (which is costly), and then filters against that. Performance was worse if I ran into scenarios that require pagination (not really an issue here because users rarely have more than 500 pieces of content, but may be an issue if we move forward with allowing admins to view all content.)