-
Notifications
You must be signed in to change notification settings - Fork 105
Create dedicated CSS group #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 91.45% 91.52% +0.07%
==========================================
Files 47 47
Lines 5558 5557 -1
==========================================
+ Hits 5083 5086 +3
+ Misses 475 471 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@tylerriccio33 we discussed this PR earlier today and came to the conclusion that splitting out css-inline into its own group would probably make things more complicated for the average user without a clear benefit. I can definitely understand that installing an unneeded selenium dependency makes no sense, but couldn't the alternative be installing css-inline separately (i.e., independent of installing |
Yea completely get that. The problem with having a separate install of css-inline is it usually fails CI, since it's not documented in the dependency tree and it's never imported, so the linters think it's an extra dependency. It's easy to override so not a big deal! |
I would argue though the |
But if we’re not adding the second optional dependency group What does look pretty good in this PR are the additions to the Makefile. Would you be willing to close this PR and make a separate one with just the Makefile update? |
so even though it's just the extra, i still think it's beneficial to include that in the err message instead of it just saying 'run pip install '. In the change it would be 'run pip install[extra]' which is the more accurate install command. |
This is a 2-fold PR:
_try_import
function call out the dependency group needed to install said dependency instead of the generic pip install command. This would encourage users to follow best practices and add the correct group instead of one-off installing it.I did these things which are not crucial but development quality of life. Feel free to strike them from the commit!
pytest ...
. The old version would require users to activate the environment. Not sure if you want to keep this depending on your philosophy!