Frontmatter integration update for Markdown (Quarto integration)

[mcanouil]

Currently Positron uses an "old" version of the front matter specification:

• positron/extensions/markdown-basics/syntaxes/markdown.tmLanguage.json

  Lines 2482 to 2491 in c8e3bb9

  	"frontMatter": {
  	"begin": "\\A-{3}\\s*$",
  	"contentName": "meta.embedded.block.frontmatter",
  	"patterns": [
  	{
  	"include": "source.yaml"
  	}
  	],
  	"end": "(^|\\G)-{3}|\\.{3}\\s*$"
  	},

The update on VSCode caused issue with the quarto VSCode extension which can be fixed by a update of the tm language file (quarto-dev/quarto#506) but this might have some unexpected effect on Positron.

I've tested to run the development version from my Pull Request on Positron but I'm not sure the debug mode overwrite the built-in quarto extension so I am not entirely sure how it behaves on Positron.
https://files.slack.com/files-pri/T02V9CHFH-F07FFNN212R/image.png

---

From quarto-dev/quarto#501 (comment)

FrontMatter integration should be updated to match Markdowns

https://github.com/quarto-dev/quarto/blob/06678d55143a7d6de6c7f0232db0c5dcf8392ca6/apps/vscode/syntaxes/quarto.tmLanguage.yaml#L226-L231

microsoft/vscode-markdown-tm-grammar#162

https://github.com/microsoft/vscode-markdown-tm-grammar/blob/main/markdown.tmLanguage.base.yaml#L202-L216

[mcanouil]

FYI, it appears (at least from my tests) the issue on VSCode is on everything but macOS.
Below a screen recording switching from macOS to Debian via DevContainer.

Screen.Recording.2024-08-05.at.16.38.51.mov

[juliasilge]

The only way I know to really be sure you are using the dev version of an extension is to remove the builtin one, i.e. like:

rm -r /Applications/Positron.app/Contents/Resources/app/extensions/quarto.quarto

I just tested out this change by using the .vsix generated here with the current release build of Positron and all is working well. There are no problems similar to those outlined in quarto-dev/quarto#501 (comment).

I just finished up testing on macOS and will get out my Windows machine here in a bit.

FYI we plan to merge from VS Code upstream this week.

[mcanouil]

Thanks for the update.
I'm not sure the VSCode extension can really wait a week-ish as it's completely broken right now (it's more of a "ASAP" update).

[juliasilge]

Sure thing! I will sanity check on Windows and I think the Quarto extension is fine to update.

Have you checked if this new extension version works correctly with the previous VS Code version?

[mcanouil]

No, I did not.
I needed my VSCode install to be able to do my main job.

If a user doesn't update VSCode, it can also block the extension update as well.

[juliasilge]

I also just tested on Windows with:

Positron Version: 2024.07.0 (system setup) build 2024.07.0-125
Code - OSS Version: 1.91.0
Commit: cae4905
Date: 2024-07-31T22:26:02.970Z
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19045

(Note the old version of VS Code.)

Things looks fine to me:

[mcanouil]

Thanks for testing!

[juliasilge]

I believe this is addressed by #4261 @jmcphers, correct?

[mcanouil]

The Quarto extension is one thing.

There is also:

• positron/extensions/markdown-basics/syntaxes/markdown.tmLanguage.json

  Lines 2482 to 2491 in c8e3bb9

  	"frontMatter": {
  	"begin": "\\A-{3}\\s*$",
  	"contentName": "meta.embedded.block.frontmatter",
  	"patterns": [
  	{
  	"include": "source.yaml"
  	}
  	],
  	"end": "(^|\\G)-{3}|\\.{3}\\s*$"
  	},

But this might be taking care of while updating Code OSS.

By updating the extension first, the issue that occurred on VSCode won't happen on Positron in theory.

[juliasilge]

But this might be taking care of while updating Code OSS.

Yep! That is correct.

[petetronic]

We have updated Quarto to 1.114, and the markdown-basics extension's tm grammar will be updated when we update from upstream Code OSS 1.92 later this month.

[jonvanausdeln]

Verified Fixed

Positron Version(s) : 2024.08.0-77
OS Version(s) : Windows 11

Test scenario(s)

Tried a few different quarto documents and everything works as expected.

Link(s) to TestRail test cases run or created: