-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update tm language with new markdown frontmatter specs #506
Conversation
I'm not entirely sure this is enough as running Edit: I've figured the missing step: |
Also tracking the TM language change on Positron side: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .vsix
built from this PR works fine with the current release build of Positron. See some details here.
Positron won't merge the upstream Code OSS release until later this week FYI.
We will want to bump the Quarto extension version at the same time that we merge in upstream Code OSS if possible. |
Feel free to take over the PR to make the additional changes you might need (or make another PR after this one). |
Edited to clarify: From my perspective, this PR is ready to go and can be merged. ✅ Additionally perhaps separately, it would be nice to update the extension version in this repo so it makes a bit more sense for dev work. The |
Let me grab a laptop. |
I've bumped the version to 1.114.0 (minor) and added a changelog entry. |
@juliasilge FYI, I don't have any permission here so I cannot proceed further. |
I just updated my VSCode extension - and no more red text, the fix appears to be working. |
From #501 (comment)
Fixes #501, fixes #504, fixes #505