-
Notifications
You must be signed in to change notification settings - Fork 122
python: v2025.16.0 upstream merge #10018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
extensions/positron-python/.github/instructions/learning.instructions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
applyTo: '**' | ||
description: This document describes how to deal with learnings that you make. (meta instruction) | ||
--- | ||
|
||
This document describes how to deal with learnings that you make. | ||
It is a meta-instruction file. | ||
|
||
Structure of learnings: | ||
|
||
- Each instruction file has a "Learnings" section. | ||
- Each learning has a counter that indicates how often that learning was useful (initially 1). | ||
- Each learning has a 1 sentence description of the learning that is clear and concise. | ||
|
||
Example: | ||
|
||
```markdown | ||
## Learnings | ||
|
||
- Prefer `const` over `let` whenever possible (1) | ||
- Avoid `any` type (3) | ||
``` | ||
|
||
When the user tells you "learn!", you should: | ||
|
||
- extract a learning from the recent conversation | ||
_ identify the problem that you created | ||
_ identify why it was a problem | ||
_ identify how you were told to fix it/how the user fixed it | ||
_ generate only one learning (1 sentence) that helps to summarize the insight gained | ||
- then, add the reflected learning to the "Learnings" section of the most appropriate instruction file | ||
|
||
Important: Whenever a learning was really useful, increase the counter!! | ||
When a learning was not useful and just caused more problems, decrease the counter. |
187 changes: 187 additions & 0 deletions
187
...sions/positron-python/.github/instructions/testing_feature_area.instructions.md
Large diffs are not rendered by default.
Oops, something went wrong.
79 changes: 79 additions & 0 deletions
79
extensions/positron-python/.github/prompts/extract-impl-instructions.prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
--- | ||
mode: edit | ||
--- | ||
|
||
Analyze the specified part of the VS Code Python Extension codebase to generate or update implementation instructions in `.github/instructions/<component>.instructions.md`. | ||
|
||
## Task | ||
|
||
Create concise developer guidance focused on: | ||
|
||
### Implementation Essentials | ||
|
||
- **Core patterns**: How this component is typically implemented and extended | ||
- **Key interfaces**: Essential classes, services, and APIs with usage examples | ||
- **Integration points**: How this component interacts with other extension parts | ||
- **Common tasks**: Typical development scenarios with step-by-step guidance | ||
|
||
### Content Structure | ||
|
||
````markdown | ||
--- | ||
description: 'Implementation guide for the <component> part of the Python Extension' | ||
--- | ||
|
||
# <Component> Implementation Guide | ||
|
||
## Overview | ||
|
||
Brief description of the component's purpose and role in VS Code Python Extension. | ||
|
||
## Key Concepts | ||
|
||
- Main abstractions and their responsibilities | ||
- Important interfaces and base classes | ||
|
||
## Common Implementation Patterns | ||
|
||
### Pattern 1: [Specific Use Case] | ||
|
||
```typescript | ||
// Code example showing typical implementation | ||
``` | ||
```` | ||
|
||
### Pattern 2: [Another Use Case] | ||
|
||
```typescript | ||
// Another practical example | ||
``` | ||
|
||
## Integration Points | ||
|
||
- How this component connects to other VS Code Python Extension systems | ||
- Required services and dependencies | ||
- Extension points and contribution models | ||
|
||
## Essential APIs | ||
|
||
- Key methods and interfaces developers need | ||
- Common parameters and return types | ||
|
||
## Gotchas and Best Practices | ||
|
||
- Non-obvious behaviors to watch for | ||
- Performance considerations | ||
- Common mistakes to avoid | ||
|
||
``` | ||
|
||
## Guidelines | ||
- **Be specific**: Use actual class names, method signatures, and file paths | ||
- **Show examples**: Include working code snippets from the codebase | ||
- **Target implementation**: Focus on how to build with/extend this component | ||
- **Keep it actionable**: Every section should help developers accomplish tasks | ||
|
||
Source conventions from existing `.github/instructions/*.instructions.md`, `CONTRIBUTING.md`, and codebase patterns. | ||
|
||
If `.github/instructions/<component>.instructions.md` exists, intelligently merge new insights with existing content. | ||
``` |
30 changes: 30 additions & 0 deletions
30
extensions/positron-python/.github/prompts/extract-usage-instructions.prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
--- | ||
mode: edit | ||
--- | ||
|
||
Analyze the user requested part of the codebase (use a suitable <placeholder>) to generate or update `.github/instructions/<placeholder>.instructions.md` for guiding developers and AI coding agents. | ||
|
||
Focus on practical usage patterns and essential knowledge: | ||
|
||
- How to use, extend, or integrate with this code area | ||
- Key architectural patterns and conventions specific to this area | ||
- Common implementation patterns with code examples | ||
- Integration points and typical interaction patterns with other components | ||
- Essential gotchas and non-obvious behaviors | ||
|
||
Source existing conventions from `.github/instructions/*.instructions.md`, `CONTRIBUTING.md`, and `README.md`. | ||
|
||
Guidelines: | ||
|
||
- Write concise, actionable instructions using markdown structure | ||
- Document discoverable patterns with concrete examples | ||
- If `.github/instructions/<placeholder>.instructions.md` exists, merge intelligently | ||
- Target developers who need to work with or extend this code area | ||
|
||
Update `.github/instructions/<placeholder>.instructions.md` with header: | ||
|
||
``` | ||
--- | ||
description: "How to work with the <placeholder> part of the codebase" | ||
--- | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting 👀