Auto update notification #5884
Merged
Auto update notification #5884
+383
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
jmcphers
requested changes
Jan 7, 2025
| @@ -9,6 +9,7 @@ import { ConfigurationScope, Extensions as ConfigurationExtensions, IConfigurati | |||
| import { Registry } from '../../registry/common/platform.js'; | |||
|
|
|||
| const configurationRegistry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration); | |||
| // --- START POSITRON --- | |||
There was a problem hiding this comment.
Nit, here and elsewhere: should use the standard casing for comment fences (Start Positron)
There was a problem hiding this comment.
I keep forgetting this!
| @@ -57,8 +78,11 @@ export abstract class AbstractUpdateService implements IUpdateService { | |||
| @IEnvironmentMainService private readonly environmentMainService: IEnvironmentMainService, | |||
| @IRequestService protected requestService: IRequestService, | |||
| @ILogService protected logService: ILogService, | |||
| @IProductService protected readonly productService: IProductService | |||
| // --- START POSITRON --- | |||
There was a problem hiding this comment.
Could you split this into several more granular code fences? When merging, it's important that the code fences wind up in the conflicted text.
| } | ||
|
|
||
| protected doCheckForUpdates(context: any): void { |
There was a problem hiding this comment.
It looks like this whole function from upstream got refactored out. Could you leave it in place so that it doesn't generate merge conflicts when it changes upstream? It's cool to mark it with @ts-ignore if it becomes unused.
src/vs/platform/update/test/electron-main/positronVersions.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan <[email protected]> Signed-off-by: Tim Mok <[email protected]>
jmcphers
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1837
Checks the releases JSON and determines if there is an update available. This can be manually invoked from the cog menu at the bottom of the left sidebar or Positron will do so once per hour.
The Output view shows debug messages in the Main output. It will show the update URL (points to the platform's release JSON) at startup. Update checks are logged here as well. If the update URL is unavailable, a toast notification displays the error with more details in the Output view.
There didn't seem to be a calendar versioning package that supported build numbers and zero-padding so that's why there's a Positron version utility. It seems important to know that
2024.12.0-1is older than2024.12.0-2if we want to be able to test updating private releases.There are two environment variables for internal use:
POSITRON_UPDATE_CHANNEL- The default isprereleasesbut can be set todailiesorstagingfor releases that haven't been published to Positron's releases page on GitHub.dailiesisn't auto-publishing at the moment andstaginghas a 1-day expiry.POSITRON_AUTO_UPDATE- Setting to1will automatically download the update and notify the user when it is ready to restart to complete the install. This is for testing and needs a certified build (at least on Mac).This will check is functional for all platforms with the following caveats:
systemrelease info. I think differentiating the system and user installers via a key/value inproduct.jsonwould work.debrelease info. It could use the same solution as Windows to differentiate the install type. Despite no auto-update support, it might be useful to know.Manual check when there are no updates available
Update is available as indicated by the bottom of the left sidebar
The cog menu will change the check update action to download the update. This download action opens Positron's releases page in the user's browser.
QA Notes
Positron Builds can run the action to push a staging release if we want to run an internal test. This is experimental as the generated release info may be stale (rerunning doesn't automatically update the hosted file) or expired (file is auto-deleted after one day).