Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat append incremental #1799

Merged
merged 9 commits into from
Dec 21, 2024
+10 −4
Merged

Chat append incremental #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c7e0786
Allow appending of message content incrementally
jcheng5 Aug 29, 2024
4e231d5
Fix chat append for chunk type of "end"
jcheng5 Aug 29, 2024
a8f9a50
Merge remote-tracking branch 'origin/main' into chat-append-incremental
jcheng5 Oct 9, 2024
1b87193
Remove vestigial is_streaming attribute
jcheng5 Oct 9, 2024
e8d1e2c
Immediately add shiny custom message handler
cpsievert Oct 10, 2024
7ad3a68
Merge branch 'main' into chat-append-incremental
cpsievert Oct 15, 2024
70c6c99
Revert "Immediately add shiny custom message handler"
cpsievert Oct 15, 2024
005b556
Merge branch 'main' into chat-append-incremental
cpsievert Oct 16, 2024
288945c
Merge branch 'main' into chat-append-incremental
cpsievert Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion js/chat/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type Message = {
role: "user" | "assistant";
chunk_type: "message_start" | "message_end" | null;
content_type: ContentType;
operation: "append" | null;
};
type ShinyChatMessage = {
id: string;
Expand Down Expand Up @@ -423,7 +424,12 @@ class ChatContainer extends LightElement {
return;
}

lastMessage.setAttribute("content", message.content);
const content =
message.operation === "append"
? lastMessage.getAttribute("content") + message.content
: message.content;

lastMessage.setAttribute("content", content);

if (message.chunk_type === "message_end") {
this.lastMessage?.removeAttribute("streaming");
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/py-shiny/chat/chat.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading