Skip to content

Commit

Permalink
Remove widget container after plotly widget view gets destroyed (#178)
Browse files Browse the repository at this point in the history
  • Loading branch information
cpsievert authored Jan 23, 2025
1 parent 62489d8 commit a315cc7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to shinywidgets will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [UNRELEASED] - 2025-01-23

* Fixed an issue with plotly graphs sometimes not getting fully removed from the DOM. (#178)

## [0.4.2] - 2024-12-18

* Fixed an issue where `@render_widget` would sometimes incorrectly render a new widget without removing the old one. (#167)
Expand Down
2 changes: 2 additions & 0 deletions js/src/output.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ Shiny.addCustomMessageHandler("shinywidgets_comm_close", async (msg_txt) => {
// way to drop the resize event listener (see the diff in the link above)
// https://github.com/posit-dev/py-shinywidgets/issues/166
delete v.model;
// Ensure sure the lm-Widget container is also removed
v.remove();
}


Expand Down
2 changes: 1 addition & 1 deletion shinywidgets/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

__author__ = """Carson Sievert"""
__email__ = "[email protected]"
__version__ = "0.4.2"
__version__ = "0.4.2.9000"

from ._as_widget import as_widget
from ._dependencies import bokeh_dependency
Expand Down
Loading

0 comments on commit a315cc7

Please sign in to comment.