fix: change send button selector to a specific class instead of generic <button> #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic <button> This enables usage of JS injection for additional buttons without breaking functionality for those buttons or the send button. This also opens up a potential plugin buttons approach where a user could choose if they want to include more buttons (this is more a suggestion).
DeepanshKhurana
commented
Sep 26, 2025
| self.loc_input_container = self.loc.locator("> shiny-chat-input") | ||
| self.loc_input = self.loc_input_container.locator("textarea") | ||
| self.loc_input_button = self.loc_input_container.locator("button") | ||
| self.loc_input_button = self.loc_input_container.locator("button.chat-send-button") |
There was a problem hiding this comment.
I couldn't find an equivalent test for R but I figured it makes sense to repair the Python test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
This enables usage of JS injection for additional buttons without breaking functionality for those buttons or the send button. This also opens up a potential plugin buttons approach where a user could choose if they want to include more buttons (this is more a suggestion). But mostly, this makes things more customisable for advanced users.