Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLM-Events Tab to Display Only Conversations Matching a filter #30

Open
wants to merge 6 commits into
base: llm-main
Choose a base branch
from

Conversation

AndrMoura
Copy link
Collaborator

@AndrMoura AndrMoura commented Jun 17, 2024

Problem

The llm-events tab is displaying all user sessions/conversations without accounting for a given filter. When a filter is set to flag conversations with a toxic property, it shows all conversations for the user, regardless of whether they are toxic or not. This makes it hard to find the correct sessions that match the filter.

Changes

Backend: Extract the session IDs that match the filter and retain only the matching sessions.

Copy link
Contributor

Hey @AndrMoura! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

📸 UI snapshots have been updated

11 snapshot changes in total. 0 added, 11 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@AndrMoura AndrMoura changed the title [DRAFT] - view llm-events with filters w/o session_id (wip) Fix LLM-Events Tab to Display Only Conversations Matching a filter Jun 20, 2024
@AndrMoura AndrMoura requested a review from pvl June 20, 2024 14:06
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant