-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi-platform Docker images #3029
base: develop
Are you sure you want to change the base?
feat: multi-platform Docker images #3029
Conversation
# Why More and more systems are running on the arm64 platform. For example, AWS EC2 instances with Graviton2 processors or ARM-based MacBooks. One of our customers is facing issues, because Newman does not run on ARM-based systems. More specifically, the `postman/newman` Docker image only supports the `linux/amd64` platform. # What This change enables the creation of `linux/amd64` and `linux/arm64` Docker images. The change also removes the Docker image definition for Ubuntu 14.04 and Alpine 3.3. Both of these newman Docker images haven't been published in two years and can therefore be removed.
Codecov Report
@@ Coverage Diff @@
## develop #3029 +/- ##
========================================
Coverage 90.96% 90.96%
========================================
Files 21 21
Lines 1151 1151
Branches 349 349
========================================
Hits 1047 1047
Misses 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hello, |
We're running into this too. |
We are deploying Testkube internally, and we are running on this issue too. Latest postman/newman tag is 2 years old and only AMD64 :S |
@@ -1,7 +1,7 @@ | |||
FROM ubuntu:18.04 | |||
LABEL maintainer="Postman Labs <[email protected]>" | |||
|
|||
ARG NODE_VERSION=10 | |||
ARG NODE_VERSION=16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current NodeJS LTS is 20
, but Nodesource only supports up to 16
on ubuntu:18.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this PR is about a year old. I no longer have a need for these changes and will therefore not work on this PR anymore. Feel free to pick up on this state.
Why
More and more systems are running on the arm64 platform. For example, AWS EC2 instances with Graviton2 processors or ARM-based MacBooks. One of our customers is facing issues, because Newman does not run on ARM-based systems. More specifically, the
postman/newman
Docker image only supports thelinux/amd64
platform.What
This change enables the creation of
linux/amd64
andlinux/arm64
Docker images.The change also removes the Docker image definition for Ubuntu 14.04 and Alpine 3.3. Both of these newman Docker images haven't been published in two years and can therefore be removed.
Trial Run
Here are the generated Docker images and tags for the latest newman version across for the
develop and master branch.
develop branch:
master branch: